Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--keep-unreferenced-defs does not work consistently for all elements #18

Closed
Ede123 opened this issue Nov 22, 2015 · 0 comments · Fixed by #62
Closed

--keep-unreferenced-defs does not work consistently for all elements #18

Ede123 opened this issue Nov 22, 2015 · 0 comments · Fixed by #62
Labels
bug

Comments

@Ede123
Copy link
Member

Ede123 commented Nov 22, 2015

I just noticed that even if I provide the --keep-unreferenced-defs command line argument (added in e01fac8) unreferenced gradient definitions are still stripped from the output.

It does work for other elements, tough, e.g. a <rect>.

I suggest fixing this to work for all definitions or updating the documentation accordingly since intuitively I'd assumed this option to be aimed towards gradients (which is obviously not the case).

Pinging @flosse who submitted the relevant PR #2 so he can have a look.
@oberstet oberstet added the bug label Dec 10, 2015
Ede123 added a commit to Ede123/scour that referenced this issue Aug 14, 2016
@Ede123
Don't remove unreferenced defs if --keep-unreferenced-defs is speci…
fcddf97 
…fied

(fixes scour-project#18)
@Ede123 Ede123 mentioned this issue Aug 14, 2016
Merged
Ede123 added a commit that referenced this issue Aug 14, 2016
@Ede123
Don't remove unreferenced defs if --keep-unreferenced-defs is speci…
fe2884c 
…fied (#62)

* Don't remove unreferenced defs if `--keep-unreferenced-defs` is specified
(fixes #18)

* Add unittests for previous commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't remove unreferenced defs if --keep-unreferenced-defs is specified Ede123/scour
2 participants
@oberstet @Ede123