Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust repo settings for Travis integration #54

Closed
oberstet opened this issue Apr 3, 2016 · 23 comments
Closed

Adjust repo settings for Travis integration #54

oberstet opened this issue Apr 3, 2016 · 23 comments

Comments

@oberstet
Copy link
Member

oberstet commented Apr 3, 2016

@codedread Hi Jeff, we need your help;)

In this Eduard (@Ede123) has added Travis and Tox support. This is for automatically testing installation and unit tests on various Python environments. Eg see the output here https://travis-ci.org/Ede123/scour/builds/120307796

Now, we can make above tests run full automatically on new/modified PRs, and immediately see if there is something bad inside, eg have a look at crossbario/txaio#59 and the test results https://travis-ci.org/crossbario/txaio/builds/118453232

For Travis integration, this repo needs to be wired up to Travis. This is easy and quick, but can only be done by repo admins.

So I would like to ask if you support these efforts?

If so, you would need an account on https://travis-ci.org/, and then go to "Settings => Webhooks => Add .. Travis"

@Ede123
Copy link
Member

Ede123 commented Apr 3, 2016

Since I just did this step for my fork I can say that it's even easier nowadays:

  • Just visit https://travis-ci.org
  • There you can "Sign in with GitHub" which automatically authorizes Travis in GitHub via OAuth
  • Afterwards you only have to "Flick the repository switch on" in your Travis profile (your repositories will be auto-detected after initial login) which effectively enables Travis build checking and automatically adds said webhook.

@oberstet
Copy link
Member Author

oberstet commented Apr 3, 2016

@Ede123 The downside of that (automatic) way is that Travis will require a extended permissions on your repo.

@Ede123
Copy link
Member

Ede123 commented Apr 3, 2016

That is true, Travis requests the following permissions

  • Read org and team membership
  • Access commit status
  • Access deployment status
  • Access user email addresses (read-only)
  • Write repository hooks

@oberstet
Copy link
Member Author

oberstet commented Apr 3, 2016

Oh, nice. This seems to have changed. A write permission to a repository, but specific to repository hooks. If above is the new set of permissions, these are reasonable. So the automatic method is fine in this respect too now.

@Ede123
Copy link
Member

Ede123 commented Apr 18, 2016

Hm, seems @codedread is on holiday? (At least that's where I'd be 😉)

@oberstet
Copy link
Member Author

@Ede123 Holidays .. what's that? ;)

Travis CI would be a nice addition to this project. I think it's worth and deserves it. Also, as you already did all the hard work of migrating the unit tests here ..

@Ede123
Copy link
Member

Ede123 commented Jun 17, 2016

@oberstet Did you receive my mail regarding transfer of the project to an organization Tobias? (I sent it to the mail address you use in your commits). You could share owner rights with Jeff then...

@oberstet
Copy link
Member Author

@Ede123 What is the state of our discussion moving this repo (again) to somewhere else? Did I miss anything? I am open to move it, but please lets make that then the last move;)

@oberstet
Copy link
Member Author

@Ede123 I am also open to share admin/merge rights with you, as you seem to be motivated and skilled in the area - and me I am drowning in other things ..

@Ede123
Copy link
Member

Ede123 commented Jul 25, 2016

Last response by @codedread was, that he will delay the move until he's
back from holiday (don't know when that is). Otherwise I think we'd be fine.

I'd be happy to support the project, however it would he nice if you could
still review more complex changes since you obviously are much more
experienced.

Last but not least I'm on holiday and traveling myself right now, so I
won't have access to a computer in the next two weeks and you should expect
delays in my answers.

Am 25. Juli 2016 3:55:20 vorm. schrieb Tobias Oberstein
notifications@github.com:

@Ede123 I am also open to share admin/merge rights with you, as you seem to
be motivated and skilled in the area - and me I am drowning in other things ..


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#54 (comment)

@oberstet
Copy link
Member Author

@Ede123 No worries - have a nice trip!

Of course I will continue to support/review stuff around. We pretty much depend on Inkscape/Scour for all of our Web sites. It's just that I thought you are much more involved in Inkscape/SVG in general compared to me. And can also act as a "hub" towards Inkscape - which pretty much is the whole reason I got into Scour anyways;) It is important to "connect communities", and for that you need guys involved at both ends ..

@codedread
Copy link
Collaborator

I'm back from holiday and can help out (or enable folks to move it). Can
someone clarify what the move is and what I need to do?

I'm the least involved with Scour between us three these days :D

Jeff

On Mon, 25 Jul 2016 at 07:23 Eduard Braun notifications@github.com wrote:

Last response by @codedread was, that he will delay the move until he's
back from holiday (don't know when that is). Otherwise I think we'd be
fine.

I'd be happy to support the project, however it would he nice if you could
still review more complex changes since you obviously are much more
experienced.

Last but not least I'm on holiday and traveling myself right now, so I
won't have access to a computer in the next two weeks and you should
expect
delays in my answers.

Am 25. Juli 2016 3:55:20 vorm. schrieb Tobias Oberstein
notifications@github.com:

@Ede123 I am also open to share admin/merge rights with you, as you seem
to
be motivated and skilled in the area - and me I am drowning in other
things ..


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#54 (comment)


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#54 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGIDIdEqxIJX6BafRGPShhqy6e7FxCvks5qZMbHgaJpZM4H-fZU
.

@codedread
Copy link
Collaborator

Ok, figured it out - I have transferred codedread/scour repo to
scour-project/scour. scour-project is the Github organization that Eduard
and I are in.

On Mon, 25 Jul 2016 at 22:27 Jeff Schiller codedread@gmail.com wrote:

I'm back from holiday and can help out (or enable folks to move it). Can
someone clarify what the move is and what I need to do?

I'm the least involved with Scour between us three these days :D

Jeff

On Mon, 25 Jul 2016 at 07:23 Eduard Braun notifications@github.com
wrote:

Last response by @codedread was, that he will delay the move until he's
back from holiday (don't know when that is). Otherwise I think we'd be
fine.

I'd be happy to support the project, however it would he nice if you
could
still review more complex changes since you obviously are much more
experienced.

Last but not least I'm on holiday and traveling myself right now, so I
won't have access to a computer in the next two weeks and you should
expect
delays in my answers.

Am 25. Juli 2016 3:55:20 vorm. schrieb Tobias Oberstein
notifications@github.com:

@Ede123 I am also open to share admin/merge rights with you, as you
seem to
be motivated and skilled in the area - and me I am drowning in other
things ..


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#54 (comment)


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#54 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGIDIdEqxIJX6BafRGPShhqy6e7FxCvks5qZMbHgaJpZM4H-fZU
.

@oberstet
Copy link
Member Author

@codedread Great, thanks! Could you give me admin rights to the repo?

@codedread
Copy link
Collaborator

Invite sent

On Tue, 26 Jul 2016 at 07:50 Tobias Oberstein notifications@github.com
wrote:

@codedread https://github.com/codedread Great, thanks! Could you give
me admin rights to the repo?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#54 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGIDM6PgTrOG-z2MSLR97yOwWonva6Bks5qZh7KgaJpZM4H-fZU
.

@oberstet
Copy link
Member Author

@codedread Mmh, something seem to went wrong .. I didn't get an invite. Usually, you (as an owner/admin) will have a "Settings" tab to the very right/top on the repo. There, go to "Collaborators & Teams" .. there you can configure who has what permissions. I would need to be "Admin" to be able to setup Travis integration and such. Have a look at one of our repos here http://picpaste.com/pics/Bildschirmfoto_vom_2016-07-28_15_27_01-F0fJDkpL.1469712448.png

@codedread
Copy link
Collaborator

Hi Tobias,

I sent you an invite to the scour-project organization (see screenshot).
Can you look for an invite for that? I have tried to send it again.

Once you're part of that organization, I will make you an admin so you can
administer all the things (there's only one repo managed by that org, the
scour repo).

Jeff
[image: Screen Shot 2016-07-29 at 11.30.30 AM.png][image: Screen Shot
2016-07-29 at 11.31.36 AM.png]

On Thu, 28 Jul 2016 at 06:28 Tobias Oberstein notifications@github.com
wrote:

@codedread https://github.com/codedread Mmh, something seem to went
wrong .. I didn't get an invite. Usually, you (as an owner/admin) will have
a "Settings" tab to the very right/top on the repo. There, go to
"Collaborators & Teams" .. there you can configure who has what
permissions. I would need to be "Admin" to be able to setup Travis
integration and such. Have a look at one of our repos here
http://picpaste.com/pics/Bildschirmfoto_vom_2016-07-28_15_27_01-F0fJDkpL.1469712448.png


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#54 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGIDE4i0Vmkp4u1P9V7gQGReqJNH-Tzks5qaK53gaJpZM4H-fZU
.

@codedread
Copy link
Collaborator

Ok, I also added you explicitly as an Admin of the scour repo:

[image: Screen Shot 2016-07-29 at 11.32.56 AM.png]

On Fri, 29 Jul 2016 at 11:32 Jeff Schiller codedread@gmail.com wrote:

Hi Tobias,

I sent you an invite to the scour-project organization (see screenshot).
Can you look for an invite for that? I have tried to send it again.

Once you're part of that organization, I will make you an admin so you can
administer all the things (there's only one repo managed by that org, the
scour repo).

Jeff
[image: Screen Shot 2016-07-29 at 11.30.30 AM.png][image: Screen Shot
2016-07-29 at 11.31.36 AM.png]

On Thu, 28 Jul 2016 at 06:28 Tobias Oberstein notifications@github.com
wrote:

@codedread https://github.com/codedread Mmh, something seem to went
wrong .. I didn't get an invite. Usually, you (as an owner/admin) will have
a "Settings" tab to the very right/top on the repo. There, go to
"Collaborators & Teams" .. there you can configure who has what
permissions. I would need to be "Admin" to be able to setup Travis
integration and such. Have a look at one of our repos here
http://picpaste.com/pics/Bildschirmfoto_vom_2016-07-28_15_27_01-F0fJDkpL.1469712448.png


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#54 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGIDE4i0Vmkp4u1P9V7gQGReqJNH-Tzks5qaK53gaJpZM4H-fZU
.

@oberstet
Copy link
Member Author

@codedread thanks! that workered. I could already review and merge a PR, and also are able to change repo settings - which is needed to setup Travis ..

@oberstet
Copy link
Member Author

@codedread @Ede123 alright, I have setup Travis integration .. it'll kick in for each commit pushed. As you can see, something fails for py 2.6: https://travis-ci.org/scour-project/scour/builds/148530565 - so it works! ;)

@Ede123
Copy link
Member

Ede123 commented Aug 5, 2016

@oberstet - Yes, the error was introduced in 1a8ece2 (Python 2.6. doesn't like the call of assertRaises() in the unittest for DocWithFlowtext).

Should we fix it or simply drop official support for Python 2.6? Inkscape distributions for Windows will bundle Python 2.7 in future, so my biggest concern is resolved.
Do you know if any common Linux distro still relies on Python 2.6?

@oberstet
Copy link
Member Author

oberstet commented Aug 5, 2016

@Ede123 I am +1 on dropping 2.6 support. Many major projects already did (eg Twisted).

@Ede123
Copy link
Member

Ede123 commented Aug 13, 2016

@oberstet All right, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants