Prevent all model entities from being deleted for OneToOneField relations #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99
As an extra thought, I am wondering whether there should be some configuration (either in the settings or on the models themselves) as to whether the
__class__.objects..all().delete()
is EVER called. It seems super dangerous to me and I'm not sure what it achieves? I would suggest that this code should not be run by default.For our use case, for example, we would be looking for a couple of options perhaps:
I'd be keen to understand (here or on the issue I raised) what the logic behind adding these lines of code was so that a decision can be made on the above.