Django 2.0 compatibility: Add mandatory on_delete argument to foreign keys
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm intentionally adding this to the existing migration. `makemigrations` do not create a new migration for the `on_delete` changes to the fields. I also tried adding a new model without the argument (and Django 1.11), for which the migration _did_ include the argument (defaults to `models.CASCADE`). If I explicitly removed the `on_delete` argument from that migration, added `on_delete` to the model and ran `makemigrations` again, it did not create a new migration. So I assume it's safe to just add it to the existing migration, to make it compatible with the most recent versions of Django.
|
@scoursen I tried running the test suite, but following the instructions in the README doesn't work for me, and I couldn't figure out how to get it to work. |
|
I think enough things have changed over the years that the test suite no longer works as described in the README. I'm creating an issue to fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46.