Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart render floats in charts #63

Closed
itsderek23 opened this issue May 9, 2018 · 5 comments
Closed

Smart render floats in charts #63

itsderek23 opened this issue May 9, 2018 · 5 comments

Comments

@itsderek23
Copy link
Contributor

Currently, context with Numeric values are rendered using a log-scaled histogram.

For example, response time:

image

This display format doesn't work well if the numeric has a defined range (like an account id).

Investigate treating numerics like String values if there is a limited number of unique values.

@nathansamson
Copy link

Not sure if the fix would work. If you only have 20 or so requests, and they come from 10 different users. Would this count as limited unique values?

Could we do something based on the name? Eg if the name includes ID it is treated as with defined range, otherwise as histogram?

@itsderek23
Copy link
Contributor Author

If you only have 20 or so requests, and they come from 10 different users. Would this count as limited unique values?

What I'm thinking: if the data set contains more than 80% unique values, we treat as a Numeric.

So 10 unique users would still be treated as a String and render the row charts you are looking for.

We'd also combine this eventually with #53, so if some rows are hidden, you can still select those rows.

@itsderek23
Copy link
Contributor Author

@nathansamson - try explorer again now and see if the data is rendered in a row chart.

@nathansamson
Copy link

Yep, old behaviour is back like I want :)

Thanks for the quick turn around

@itsderek23
Copy link
Contributor Author

Great! Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants