Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistencies in when reports are generated and when coverageMinimum is applied #132

Closed
RichardBradley opened this issue Aug 18, 2015 · 0 comments
Closed

Inconsistencies in when reports are generated and when coverageMinimum is applied #132

RichardBradley opened this issue Aug 18, 2015 · 0 comments

Comments

@RichardBradley
Copy link
Contributor

Currently, the coverage reports are created:

  • per-project: After a "test" run (see "postTestReport", line 122)
  • per-project: When the "coverageReport" command is called (see line 68)
  • per-build: When the "coverageAggregate" command is called (see line 87)

Currently, the coverage minimum is applied:

  • per-project: After a "test" run (see "postTestReport", line 132)
  • per-build: never

I think that it's confusing to create the reports after a test run when there is now a "coverageReport" command.

I think this should be changed so that:

The coverage reports are created:

  • per-project: When the "coverageReport" command is called
  • per-build: When the "coverageAggregate" command is called

The coverage minimum is applied:

  • per-project: When the "coverageReport" command is called
  • per-build: When the "coverageAggregate" command is called

Sound OK? I'll prepare a PR, unless you object?
RichardBradley added a commit to RichardBradley/sbt-scoverage-1 that referenced this issue Aug 19, 2015
@RichardBradley
scoverage#132 clarify when reports are generated and when minimums ar…
fdc2541 
…e applied
@RichardBradley RichardBradley mentioned this issue Aug 19, 2015
Merged
RichardBradley added a commit to RichardBradley/sbt-scoverage-1 that referenced this issue Aug 19, 2015
@RichardBradley
scoverage#132 clarify when reports are generated and when minimums ar…
5237e3d 
…e applied
RichardBradley added a commit to RichardBradley/sbt-scoverage-1 that referenced this issue Aug 19, 2015
@RichardBradley
scoverage#132 clarify when reports are generated and when minimums ar…
1c806c8 
…e applied

README changes and version increment
RichardBradley added a commit to RichardBradley/sbt-scoverage-1 that referenced this issue Aug 21, 2015
@RichardBradley
scoverage#132 update tests to reflect that coverageReport is now requ…
5a9f9bd 
…ired to generate reports
sksamuel added a commit that referenced this issue Dec 2, 2015
@sksamuel
Merge pull request #133 from RichardBradley/132-coverageMinimum
0bf2087 
#132 clarify when reports are generated and when minimums are applied
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RichardBradley