Skip to content

Inconsistencies in when reports are generated and when coverageMinimum is applied #132

@RichardBradley

Description

@RichardBradley

Currently, the coverage reports are created:

  • per-project: After a "test" run (see "postTestReport", line 122)
  • per-project: When the "coverageReport" command is called (see line 68)
  • per-build: When the "coverageAggregate" command is called (see line 87)

Currently, the coverage minimum is applied:

  • per-project: After a "test" run (see "postTestReport", line 132)
  • per-build: never

I think that it's confusing to create the reports after a test run when there is now a "coverageReport" command.

I think this should be changed so that:

The coverage reports are created:

  • per-project: When the "coverageReport" command is called
  • per-build: When the "coverageAggregate" command is called

The coverage minimum is applied:

  • per-project: When the "coverageReport" command is called
  • per-build: When the "coverageAggregate" command is called

Sound OK? I'll prepare a PR, unless you object?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions