Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sbt-vspp for publishing the SBT plug-in in a Maven-consistent format #449

Merged
merged 1 commit into from
Jul 30, 2022

Conversation

ScalaWilliam
Copy link
Contributor

Hi @ckipp01 - I hope it would not be too much trouble to include this to your plug-in!

This is to enable usage of sbt-scoverage in Enterprise environments where only the valid-POM format is accepted for JAR downloads, enabling it for many teams to move from Gradle/Maven to SBT for their Scala (and even non-Scala projects).

The only change this does is to add extra JAR and POM to the artifact (while keeping the old structure -- and also enabling listing of this project on e.g. mvnrepository.com)

More background here: https://github.com/esbeetee/sbt-vspp/blob/main/README.md

This is to enable usage of sbt-scoverage in Enterprise environments where only the valid-POM format is accepted for JAR downloads, enabling it for many teams to move from Gradle/Maven to SBT for their Scala (and even non-Scala projects)

More background here: https://github.com/esbeetee/sbt-vspp/blob/main/README.md
@ckipp01
Copy link
Member

ckipp01 commented Jul 29, 2022

Thanks for the pr @ScalaWilliam! I consult at a fairly large company that also hit on this when we first started publishing an internal sbt plugin as our Sonatype OSS didn't have permissive set. We were able to get that changed to solve our publishing issue. However we actually never had an issue syncing with sbt plugins published to maven central even before this change.

In your README you have

Sadly, this does not follow the convention, and security scanning packages will not fetch the JAR files of plug-ins, so you cannot use them in enterprise 😧.

I understanding the mismatch, but could you explain this a bit more? What exact security scanning services are blocking this?

@ScalaWilliam
Copy link
Contributor Author

@ckipp01 so glad to hear this is familiar! I will improve the prose on the doc but as a general principle, vulnerability scanning + expecting valid POM.

Thank you for the great question, i updated the README with a new section to add a bit more explanation and detail :-) - hope that suffices.

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a try, thanks @ScalaWilliam. I hope this lands in sbt 2.x.

@ckipp01 ckipp01 merged commit 206a7c1 into scoverage:main Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants