Build CrossVersion.full #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blast-hardcheese
force-pushed
the
build-cross-version-full
branch
from
151cba9
to
39a65b5
Compare
blast-hardcheese
force-pushed
the
build-cross-version-full
branch
from
39a65b5
to
da6c737
Compare
|
@D-Roch Barring any objections, this is ready to go, blocking scoverage/sbt-scoverage#320 |
0xRoch
approved these changes
Feb 7, 2021
This was referenced Feb 18, 2021
Closed
|
any update on when this will be released? |
|
+1 on when this can be released, recently upgraded something to scala 2.12.13 and this plugin broke. |
finaglehelper
pushed a commit
to twitter/dodo
that referenced
this pull request
Mar 17, 2021
Problem/Solution The scoverage plugin has an issue due to a binary incompatibility introduced in scala 2.12.13 (see: scoverage/sbt-scoverage#319). It has been patched in the plugin in scoverage/scalac-scoverage-plugin#306 which is currently awaiting a release. However after updating our projects to scala 2.12.13, coverage is broken and failing the CI builds. Downgrade to scala 2.12.12 until the scoverage plugin has been published with the fix. Differential Revision: https://phabricator.twitter.biz/D635917
finaglehelper
pushed a commit
to twitter/util
that referenced
this pull request
Mar 17, 2021
Problem/Solution The scoverage plugin has an issue due to a binary incompatibility introduced in scala 2.12.13 (see: scoverage/sbt-scoverage#319). It has been patched in the plugin in scoverage/scalac-scoverage-plugin#306 which is currently awaiting a release. However after updating our projects to scala 2.12.13, coverage is broken and failing the CI builds. Downgrade to scala 2.12.12 until the scoverage plugin has been published with the fix. Differential Revision: https://phabricator.twitter.biz/D635917
finaglehelper
pushed a commit
to twitter/finagle
that referenced
this pull request
Mar 17, 2021
Problem/Solution The scoverage plugin has an issue due to a binary incompatibility introduced in scala 2.12.13 (see: scoverage/sbt-scoverage#319). It has been patched in the plugin in scoverage/scalac-scoverage-plugin#306 which is currently awaiting a release. However after updating our projects to scala 2.12.13, coverage is broken and failing the CI builds. Downgrade to scala 2.12.12 until the scoverage plugin has been published with the fix. Differential Revision: https://phabricator.twitter.biz/D635917
finaglehelper
pushed a commit
to twitter/scrooge
that referenced
this pull request
Mar 17, 2021
Problem/Solution The scoverage plugin has an issue due to a binary incompatibility introduced in scala 2.12.13 (see: scoverage/sbt-scoverage#319). It has been patched in the plugin in scoverage/scalac-scoverage-plugin#306 which is currently awaiting a release. However after updating our projects to scala 2.12.13, coverage is broken and failing the CI builds. Downgrade to scala 2.12.12 until the scoverage plugin has been published with the fix. Differential Revision: https://phabricator.twitter.biz/D635917
finaglehelper
pushed a commit
to twitter/twitter-server
that referenced
this pull request
Mar 17, 2021
Problem/Solution The scoverage plugin has an issue due to a binary incompatibility introduced in scala 2.12.13 (see: scoverage/sbt-scoverage#319). It has been patched in the plugin in scoverage/scalac-scoverage-plugin#306 which is currently awaiting a release. However after updating our projects to scala 2.12.13, coverage is broken and failing the CI builds. Downgrade to scala 2.12.12 until the scoverage plugin has been published with the fix. Differential Revision: https://phabricator.twitter.biz/D635917
finaglehelper
pushed a commit
to twitter/finatra
that referenced
this pull request
Mar 17, 2021
Problem/Solution The scoverage plugin has an issue due to a binary incompatibility introduced in scala 2.12.13 (see: scoverage/sbt-scoverage#319). It has been patched in the plugin in scoverage/scalac-scoverage-plugin#306 which is currently awaiting a release. However after updating our projects to scala 2.12.13, coverage is broken and failing the CI builds. Downgrade to scala 2.12.12 until the scoverage plugin has been published with the fix. Differential Revision: https://phabricator.twitter.biz/D635917
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for the solution to scoverage/sbt-scoverage#319
Initially publishing for more recent versions of 2.12 and 2.13 to aide in migration, since previously people were relying on unintentional bincompat between older versions of scalac.
Published versions