Skip compilation when skip scoverage to speed up build #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jozic
reviewed
Dec 26, 2023
There was a problem hiding this comment.
Hey @justinplus, thanks for your PR!
could you please add a simple integration test similar to those in it folder?
just something that will fail without your changes and pass with them
Thank you!
| @@ -212,6 +212,9 @@ public void execute() throws MojoExecutionException | |||
|
|
|||
| Properties projectProperties = project.getProperties(); | |||
|
|
|||
| // for maven-compiler-plugin (compile), scala-maven-plugin (ompile) | |||
There was a problem hiding this comment.
should be compile instead of ompile, right?
|
Hi @jozic, is there any guideline to add a new integration test? |
|
@justinplus |
|
Hey @justinplus, are you still interested in this PR? |
|
Hey @justinplus |
|
@jozic Sorry for the delay, I would continue on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when set
skipastruein the configuration section of scoverage plugin, onlytestCompileandtestare skipped for plugins likemaven-compiler-pluginandscalatest-maven-plugin.This PR set
maven.main.skipas true in project property to skip compilation of main as well to speed up build.