Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniform Response or Not #4

Open
scozv opened this issue Sep 4, 2016 · 0 comments
Open

Uniform Response or Not #4

scozv opened this issue Sep 4, 2016 · 0 comments

Comments

@scozv
Copy link
Owner

scozv commented Sep 4, 2016 •
edited

Bolero recommends an uniform HTTP Response design, that is all HTTP Response will be formatted as:

{
  ok: Boolean,
  data: T
  error: String
}

see

app/controllers/CanResponse.scala
app/models/interop/HTTPResponse.scala
scozv pushed a commit that referenced this issue Sep 4, 2016
see #4 refactor CanResponse in order to emit Json.toJson
a95614a
scozv pushed a commit that referenced this issue Sep 4, 2016
see #3 see #4 change the payload and response format of PUT /tx/:id
5b7c0e8
scozv pushed a commit that referenced this issue Sep 4, 2016
see #3 see #4 change response format of GET /tx/:id
0a2e41f
scozv pushed a commit that referenced this issue Sep 4, 2016
see #3 see #4 change response format of GET /tx/types/:tp
54bde8a
scozv pushed a commit that referenced this issue Sep 4, 2016
see #3 see #4 change response format of GET /tx/sum/:id
5a21f47
@scozv scozv mentioned this issue Sep 4, 2016
Open
scozv added a commit that referenced this issue May 29, 2022
@scozv
see #4 refactor CanResponse in order to emit Json.toJson
0c01c52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scozv