Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review clip_plane_equation #233

Closed
Echelon9 opened this issue Jul 11, 2015 · 1 comment
Closed

Review clip_plane_equation #233

Echelon9 opened this issue Jul 11, 2015 · 1 comment

Comments

@Echelon9
Copy link
Contributor

In commit c620372, a variable vec4 clip_plane_equation was added to opengl_tnl_set_material(). However, the variable is not actually used anywhere, which is odd.

Was this perhaps an oversight, and it should be passed to GL_state.Uniform around line 2056?

Picked up with gcc warnings.
Echelon9 referenced this issue Jul 11, 2015
Soft shadows, deferred lighting, and various major graphics optimizat…
c620372 
…ions.
@Echelon9 Echelon9 mentioned this issue Aug 15, 2015
Merged
@Echelon9
Copy link
Contributor Author

Resolved in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Echelon9