Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] updated conf parser + added cfp parsing #415

Merged
merged 20 commits into from
Apr 17, 2023

Conversation

Damien-VS
Copy link
Contributor

updated the conference parser in js

  • simplified the build file
  • Fix json date format : added millis to stick with default json timestamp
  • added cfp parser from badge code
  • Fixed some typo in events

Partially resolves issue #205

@Damien-VS Damien-VS closed this Apr 13, 2023
@Damien-VS Damien-VS reopened this Apr 13, 2023
@Damien-VS Damien-VS closed this Apr 13, 2023
@Damien-VS
Copy link
Contributor Author

fixed some path issues
+updated node to 16
+removed python deps
+added CFPs list in json file #205

@Damien-VS Damien-VS reopened this Apr 13, 2023
@scraly
Copy link
Owner

scraly commented Apr 14, 2023

The PR is finished or stull in draft? :)

@Damien-VS
Copy link
Contributor Author

Damien-VS commented Apr 17, 2023

I believe it is finnished.
I just closed/reopen after thinking about a bug in it during the night. This time, I slept on it a fex times, so it should be good 😄 .

Do you need some screens + annotations in here to parse through the thing ?
Thanks for your time 🙏

@scraly
Copy link
Owner

scraly commented Apr 17, 2023

First of all, thanks for your work! :-)
Yes if you can add some screen or anything else it will be helpful :-)

@Damien-VS
Copy link
Contributor Author

Damien-VS commented Apr 17, 2023

Some context :

we needed to have a CFP list, so I ended up rewriting the Python parser in .js.
Both to fix some bugs and also to add the cfp list in a separated .json file.

As the format changed a bit, I also fixed the frontend + a bug that bothered me much (see below)

Details

Parser

Some unparsed events are now being parsed correctly (from 1057 events to 1095 at this date)
This events are now enriched with the CFP data from the badge.
The timestamp is now standard json/js format, in (millis, not in seconds)

event json format updated from this :

[{
    "name": "Full Stack Europe",
    "date": [
      1697587200,
      1697760001
    ],
    "hyperlink": "https://fullstackeurope.com/2023",
    "location": "Antwerp (Belgium) ",
    "misc": "<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSdgQjf39QepP07gLE88g7-Cn7Xdfast_mHVSUp25CfpjAM2uw/viewform\"><img alt=\"CFP Full Stack Europe 2023\" src=\"https://img.shields.io/static/v1?label=CFP&message=until%2030-June-2023&color=green\"></a>"
  },

to this :

[{
    "name": "Full Stack Europe",
    "date": [
      1697580000000,
      1697752800000
    ],
    "hyperlink": "https://fullstackeurope.com/2023",
    "location": "Antwerp (Belgium)",
    "misc": "<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSdgQjf39QepP07gLE88g7-Cn7Xdfast_mHVSUp25CfpjAM2uw/viewform\"><img alt=\"CFP Full Stack Europe 2023\" src=\"https://img.shields.io/static/v1?label=CFP&message=until%2030-June-2023&color=green\"></a>",
    "cfp": {
        "link": "https://docs.google.com/forms/d/e/1FAIpQLSdgQjf39QepP07gLE88g7-Cn7Xdfast_mHVSUp25CfpjAM2uw/viewform",
        "until": "30-June-2023",
        "untilDate": 1711494000000
    },
    "status": "open"
},
...
]

A new file named all-cfps.json is now generated with CFP's ordered by ascending end date.
format :

[
{
    "link": "https://docs.google.com/forms/d/e/1FAIpQLSdgQjf39QepP07gLE88g7-Cn7Xdfast_mHVSUp25CfpjAM2uw/viewform",
    "until": "30-June-2023",
    "untilDate": 1711494000000,
    "conf": {
        "name": "Full Stack Europe",
        "date": [1697580000000, 1697752800000],
        "hyperlink": "https://fullstackeurope.com/2023",
        "status": "open",
        "location": "Antwerp (Belgium)"
    }
}
,...
]

UI changes

Dates with lots of events (7+) were displayed with very low contrast. Dimmed the effect by half.
before :
image

after :
image

@Pierstoval Pierstoval mentioned this pull request Apr 17, 2023
@scraly
Copy link
Owner

scraly commented Apr 17, 2023

Thx, it's really awesome!

Just a question, why the "status" is not a cfp's field? Because it's the CFP which is open and not the conference, isn't it? :-)
image

.github/workflows/ghpages.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
"until":"31-March-2023",
"untilDate":1704409200000
},
"status":"open"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the status of a CFP or a conference? This status should always be equals to "open"?
Thx :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the status of the conference.
I defaulted to 'open', but it takes the value expressed before the date

eg: "* [Pixelated] 04-05: myconf ..." --> status = pixelated

BTW, it appears mostly in 2020.md file ... because of covid, I guess

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I understand and yes we can keep it on order, for example, to add the "canceled" status possibility :)

doc lines in the githhub-actions file

Co-authored-by: Aurelie Vache <scraly@gmail.com>
@scraly scraly merged commit c8b4429 into scraly:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants