Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataStream..use(function* {}) times out during test. #33

Closed
MichalCz opened this issue Jan 22, 2019 · 1 comment
Closed

DataStream..use(function* {}) times out during test. #33

MichalCz opened this issue Jan 22, 2019 · 1 comment
Assignees
Labels
Milestone

Comments

@MichalCz
Copy link
Member

Basics
The issue affects DataStream..use(function* {})

Describe the bug
The current test times out.

To Reproduce
Steps to reproduce the behavior:

  1. Checkout this repo.
  2. npm install
  3. npm test
  4. See error:
✗ data-stream/test_use/generator
   ✓ ok(Must return a stream synchonously)
   ✓ ok(Must not be called and executed synchronously)
   ✓ equal(Must be called with self as first argument)
   ✓ equal(Additional arguments must be passed)
   ✗ fail(test timed out after 10000ms)
   ! test timed out after 10000ms

Expected behavior
Should not time out.

Test case
nodeunit-tape -t node_modules/scramjet_core/test/v1/data-stream.js

System:

  • OS: Ubuntu Server 18.04
  • Node version: v8, works on v10/latest.
  • Scramjet Version: 4.20

Additional context
It is possible that PromiseTransformStream.whenRead times out if reading beyond stream end.

@MichalCz MichalCz added the bug label Jan 22, 2019
@MichalCz MichalCz self-assigned this Jan 22, 2019
@MichalCz
Copy link
Member Author

Bad behavior of whenRead confirmed, additionally more items were read by the first item.

To be fixed in 4.20 patch.

@MichalCz MichalCz added this to the v4.20 milestone Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant