Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix this.space.getHostClient when using custom Agent #1021

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

patuwwy
Copy link
Member

@patuwwy patuwwy commented Jan 29, 2024

What?

  • Fix Accessing Hub with ManagerClient.getHostClient fails when using custom Agent
  • Added HostClient.getManagerClient()
  • start initial instances after api is started and host is connected (RunnerContext hub/space clients can operate)
  • Update tests' utils to wait for "Running" instead of "API ON"

Why?

Usage:

Clickup Task:

How it works:

Review checks:

These aspects need to be checked by the reviewer:

  • Verify and confirm operation (please post a screenshot)
  • All STH tests pass
  • All Scramjet Cloud Platform tests pass
  • Documentation is updated or no changes

@patuwwy patuwwy force-pushed the fix/runner-space-client branch 2 times, most recently from 0b67175 to 9c4cbb9 Compare January 29, 2024 21:50
@patuwwy patuwwy changed the title Fix this.space in RunnerContext Fix this.space.getHostClient when using custom Agent Jan 29, 2024
Copy link
Member

@alicja-gruzdz alicja-gruzdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic
I talked to @a-tylenda to add tests for it in a separate repo.

@patuwwy patuwwy force-pushed the fix/runner-space-client branch 3 times, most recently from 0003578 to ece70f1 Compare January 31, 2024 02:26
@patuwwy patuwwy merged commit 24b5f50 into devel Feb 5, 2024
19 checks passed
@patuwwy patuwwy deleted the fix/runner-space-client branch February 5, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants