Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runner exit #951

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Fix runner exit #951

merged 1 commit into from
Sep 25, 2023

Conversation

patuwwy
Copy link
Member

@patuwwy patuwwy commented Sep 25, 2023

What?
Revert change causing runner to not exit on Instance end.

How it works:
3dcc5640df486b350441e83c80d21b311c0ac2e4 introduced highWaterMark: 0 on output stream in CSIC:

845eb62b01877ccc4f233e6f81eda9b574292185    Add Topic Router                                

2023-09-22T08:18:10.138Z TRACE CSIController [73ab476d] Got message: SEQUENCE_COMPLETED. 
2023-09-22T08:18:10.136Z DEBUG Runner [73ab476d] Sequence stream ended 
2023-09-22T08:18:10.137Z TRACE Runner [73ab476d] Sequence completed. Waiting 10000ms with exit. 
2023-09-22T08:18:10.139Z DEBUG SocketServer Channel [73ab476d-06de-4825-9e3d-44120e823fb6:6] ended 
2023-09-22T08:18:16.822Z INFO  Host List Instances 
2023-09-22T08:18:16.824Z DEBUG Host Request [ 'date: 2023-09-22T08:18:16.823Z, method: GET, url: /api/v1/instances, status: 200' ]
2023-09-22T08:18:20.341Z DEBUG SocketServer Channel [73ab476d-06de-4825-9e3d-44120e823fb6:0] ended 
2023-09-22T08:18:20.342Z DEBUG SocketServer Channel [73ab476d-06de-4825-9e3d-44120e823fb6:1] ended 
2023-09-22T08:18:20.342Z DEBUG SocketServer Channel [73ab476d-06de-4825-9e3d-44120e823fb6:2] ended 
2023-09-22T08:18:20.343Z DEBUG SocketServer Channel [73ab476d-06de-4825-9e3d-44120e823fb6:3] ended 
2023-09-22T08:18:20.343Z DEBUG SocketServer Channel [73ab476d-06de-4825-9e3d-44120e823fb6:4] ended 
2023-09-22T08:18:20.344Z DEBUG SocketServer Channel [73ab476d-06de-4825-9e3d-44120e823fb6:5] ended 
2023-09-22T08:18:20.345Z DEBUG SocketServer Channel [73ab476d-06de-4825-9e3d-44120e823fb6:7] ended 
2023-09-22T08:18:20.345Z DEBUG SocketServer Channel [73ab476d-06de-4825-9e3d-44120e823fb6:8] ended 
2023-09-22T08:18:20.369Z TRACE ProcessInstanceAdapter [73ab476d] Runner process exited [ 2968453 ]
2023-09-22T08:18:20.370Z INFO  CSIController [73ab476d] Cleanup completed 
2023-09-22T08:18:20.370Z TRACE CSIController [73ab476d] Instance ended with code [ 0 ]

3dcc5640df486b350441e83c80d21b311c0ac2e4    Fix circular references in ObjLogger    

2023-09-22T08:14:56.180Z TRACE CSIController [692496a2] Got message: SEQUENCE_COMPLETED. 
2023-09-22T08:14:56.179Z DEBUG Runner [692496a2] Sequence stream ended 
2023-09-22T08:14:56.179Z TRACE Runner [692496a2] Sequence completed. Waiting 10000ms with exit. 
2023-09-22T08:15:06.384Z DEBUG SocketServer Channel [692496a2-abfc-4390-ac81-f15db4f7fff0:0] ended 
2023-09-22T08:15:06.385Z DEBUG SocketServer Channel [692496a2-abfc-4390-ac81-f15db4f7fff0:1] ended 
2023-09-22T08:15:06.386Z DEBUG SocketServer Channel [692496a2-abfc-4390-ac81-f15db4f7fff0:2] ended 
2023-09-22T08:15:06.386Z DEBUG SocketServer Channel [692496a2-abfc-4390-ac81-f15db4f7fff0:3] ended 
2023-09-22T08:15:06.387Z DEBUG SocketServer Channel [692496a2-abfc-4390-ac81-f15db4f7fff0:4] ended 
2023-09-22T08:15:06.388Z DEBUG SocketServer Channel [692496a2-abfc-4390-ac81-f15db4f7fff0:5] ended 
2023-09-22T08:15:06.388Z DEBUG SocketServer Channel [692496a2-abfc-4390-ac81-f15db4f7fff0:7] ended 
2023-09-22T08:15:06.389Z DEBUG SocketServer Channel [692496a2-abfc-4390-ac81-f15db4f7fff0:8] ended 
2023-09-22T08:15:09.864Z INFO  Host List Instances 
2023-09-22T08:15:09.865Z DEBUG Host Request [ 'date: 2023-09-22T08:15:09.864Z, method: GET, url: /api/v1/instances, status: 200' ]
2023-09-22T08:15:11.181Z TRACE CSIController [692496a2] Sequence didn't terminate itself in expected time [ 15000 ]
2023-09-22T08:15:11.198Z TRACE ProcessInstanceAdapter [692496a2] Runner process exited [ 2966745 ]
2023-09-22T08:15:11.199Z WARN  ProcessInstanceAdapter [692496a2] Runner was killed by a signal, and didn't return a status code [ 'SIGTERM' ]
2023-09-22T08:15:11.199Z ERROR CSIController [692496a2] Crashlog [ [ '', '{"msg":"Monitoring interval removed","level":"TRACE","ts":1695370506382,"from":"Runner","Runner":{"id":"692496a2-abfc-4390-ac81-f15db4f7fff0"}}\n{"msg":"Cleaning up streams","level":"INFO","ts":1695370506382,"from":"Runner","Runner":{"id":"692496a2-abfc-4390-ac81-f15db4f7fff0"}}\n{"msg":"Disconnecting from host","level":"TRACE","ts":1695370506382,"from":"HostClient","HostClient":{"id":"692496a2-abfc-4390-ac81-f15db4f7fff0"},"Runner":{"id":"692496a2-abfc-4390-ac81-f15db4f7fff0"}}\n' ] ]
2023-09-22T08:15:11.199Z INFO  CSIController [692496a2] Cleanup completed 
2023-09-22T08:15:11.200Z TRACE CSIController [692496a2] Instance ended with code [ 137 ]

Review checks:

These aspects need to be checked by the reviewer:

  • Verify and confirm operation (please post a screenshot)
  • All STH tests pass
  • All Scramjet Cloud Platform tests pass
  • Documentation is updated or no changes

@patuwwy patuwwy added bug Something isn't working group:lifecycle Issues close to lifecycle adapters group:core Issues that involve core system labels Sep 25, 2023
@patuwwy patuwwy merged commit 0863af1 into devel Sep 25, 2023
38 checks passed
@patuwwy patuwwy deleted the fix/runner-exit branch September 25, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working group:core Issues that involve core system group:lifecycle Issues close to lifecycle adapters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants