Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type change in order to achieve coherent structure for displaying #960

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

gzukowski
Copy link
Contributor

@gzukowski gzukowski commented Oct 12, 2023

What?
Added a new type for displaying sequences.

Why?
Docker's config contains "config" and "container" in fields, which are not coherent with the structure of displaying.

ClickUp task:
https://app.clickup.com/t/24308805/VDM-1440

These aspects need to be checked by the reviewer:

  • Verify and confirm operation (please post a screenshot)
  • All STH tests pass
  • All Scramjet Cloud Platform tests pass
  • Documentation is updated or no changes

@gzukowski gzukowski changed the title pul Type change in order to achieve coherent structure for displaying Oct 12, 2023
packages/types/src/runner-config.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@kociolekscramjet kociolekscramjet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frontend will work with these changes

@alicja-gruzdz
Copy link
Member

@alicja-gruzdz alicja-gruzdz merged commit 02edd75 into devel Jan 16, 2024
19 checks passed
@alicja-gruzdz alicja-gruzdz deleted the fix/all_sequences branch January 16, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants