Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Remove session configs with write access #970

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

patuwwy
Copy link
Member

@patuwwy patuwwy commented Oct 26, 2023

What?
Deleting only those configuration files to which we have write permission

If several users use si, configuration files may be created with different permissions (depending on the system settings - umask). If a user using si automatically creates a directory with the configuration for the current session, it may not be deleted by another user when the session ends.
I added a check to see if we have write access when filtering directories to delete

Review checks:

These aspects need to be checked by the reviewer:

  • Verify and confirm operation (please post a screenshot)
  • All STH tests pass
  • All Scramjet Cloud Platform tests pass
  • Documentation is updated or no changes

@alicja-gruzdz
Copy link
Member

excellent, thanks, Patryk.
LInking issue #961

@patuwwy patuwwy merged commit b9747e9 into devel Oct 30, 2023
38 checks passed
@patuwwy patuwwy deleted the fix/clr-sessions branch October 30, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants