[CLI] Remove session configs with write access #970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Deleting only those configuration files to which we have write permission
If several users use
si
, configuration files may be created with different permissions (depending on the system settings - umask). If a user usingsi
automatically creates a directory with the configuration for the current session, it may not be deleted by another user when the session ends.I added a check to see if we have write access when filtering directories to delete
Review checks:
These aspects need to be checked by the reviewer: