Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging circular args #977

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Fix logging circular args #977

merged 1 commit into from
Nov 2, 2023

Conversation

patuwwy
Copy link
Member

@patuwwy patuwwy commented Nov 1, 2023

What?
Latest change in logger has introduced error when logging circular arguments.
This is fix

Why?

Usage:

Clickup Task:

How it works:

Review checks:

These aspects need to be checked by the reviewer:

  • Verify and confirm operation (please post a screenshot)
  • All STH tests pass
  • All Scramjet Cloud Platform tests pass
  • Documentation is updated or no changes

ErykSol
ErykSol previously requested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@ErykSol ErykSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a proposition, as it's more verbose on catch block about the problem

packages/obj-logger/src/obj-logger.ts Show resolved Hide resolved
packages/obj-logger/src/obj-logger.ts Show resolved Hide resolved
@patuwwy patuwwy requested a review from ErykSol November 2, 2023 08:45
@patuwwy patuwwy merged commit 8e5d264 into devel Nov 2, 2023
38 checks passed
@patuwwy patuwwy deleted the fix/logger-circular branch November 2, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alicja-gruzdz alicja-gruzdz alicja-gruzdz approved these changes

@a-tylenda a-tylenda Awaiting requested review from a-tylenda

@ErykSol ErykSol Awaiting requested review from ErykSol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patuwwy @alicja-gruzdz @ErykSol