Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Add missing hostClient types #982

Merged
merged 1 commit into from
Nov 9, 2023
Merged

[FIX] Add missing hostClient types #982

merged 1 commit into from
Nov 9, 2023

Conversation

a-tylenda
Copy link
Contributor

What?
There were a few types missing, which caused some hostClient methods were not available in the Sequence context.
Also, there was a discrepancy in the default topic content types between getTopic() and sendTopic(). This PR also fixes that.

The default contentType for both getTopic() and sendTopic() is set to application/x-ndjson, the same as in CLI.

Thanks @patuwwy!

Why?

Usage:

Clickup Task:

How it works:

Review checks:

These aspects need to be checked by the reviewer:

  • Verify and confirm operation (please post a screenshot)
  • All STH tests pass
  • All Scramjet Cloud Platform tests pass
  • Documentation is updated or no changes

@patuwwy patuwwy merged commit fbca141 into devel Nov 9, 2023
19 checks passed
@patuwwy patuwwy deleted the fix/host-client-types branch November 9, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants