Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default runner envs with --runner-envs STH param #986

Merged
merged 8 commits into from
Nov 27, 2023

Conversation

piotrek6641
Copy link
Contributor

@piotrek6641 piotrek6641 commented Nov 13, 2023

Added option to start declare env variablers when starting sth

Example:

DEVELOPMENT=1 yarn start:dev --runner-envs "KEY1=VALUE1;KEY2=VALUE2"

Only acceptable format is providing variables in a key:value format with a space between them.
Otherwise error will be thrown

Clickup Task:
https://app.clickup.com/t/24308805/VDM-1268

@patuwwy
Copy link
Member

patuwwy commented Nov 14, 2023

Please consider my suggestion from clickup task

@piotrek6641 piotrek6641 marked this pull request as draft November 15, 2023 10:59
@piotrek6641 piotrek6641 marked this pull request as ready for review November 15, 2023 16:51
Co-authored-by: Patryk Falba <patuwwy@gmail.com>
Copy link
Member

@patuwwy patuwwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see suggestions

Copy link
Member

@patuwwy patuwwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see formating suggestions

Co-authored-by: Patryk Falba <patuwwy@gmail.com>
@alicja-gruzdz
Copy link
Member

excellent, thanks @piotrek6641
I have only one comment about naming. Option -e maybe confused with -E (--identify-existing). Perhaps we should leave only --runner-envs option. Unless you have an idea how to change these naming to differentiate between them - ?

@alicja-gruzdz
Copy link
Member

Verify:
Screenshot from 2023-11-27 12-14-30
Seems to work nicely, thanks!

@patuwwy patuwwy changed the title --env option when starting sth Set default runner envs with --runner-envs STH param Nov 27, 2023
@alicja-gruzdz alicja-gruzdz merged commit 0369394 into devel Nov 27, 2023
19 checks passed
@alicja-gruzdz alicja-gruzdz deleted the feat/start-sth-env-vars branch November 27, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants