Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOST] Api remove support for getSequenceByName #993

Merged
merged 7 commits into from
Dec 8, 2023
Merged

[HOST] Api remove support for getSequenceByName #993

merged 7 commits into from
Dec 8, 2023

Conversation

piotrek6641
Copy link
Contributor

@piotrek6641 piotrek6641 commented Nov 21, 2023 •
edited

What?

  • Change host api Api sequence endpoint to be compatible with REST standard.
  • Small changes to implement naming consistency
  • fix issues related to updating sequence via CLI. (When updating sequence cli was requesting using post method instead of put)

Endpoints before:

http://{host-apiBase}/sequence/:id_name
Accepts both id/name

After changes

http://{host-apiBase}/sequence/:id
Accepts only id now

New endpoint work structure works for all available methods for this url (GET, UPDATE, DELETE)

Clickup Task:
https://app.clickup.com/t/24308805/VDM-1423

@piotrek6641 piotrek6641 changed the title Api get sequence by Id or name [HOST] Api remove support for getSequenceByName Nov 21, 2023
@piotrek6641 piotrek6641 marked this pull request as ready for review November 29, 2023 12:01
@piotrek6641 piotrek6641 linked an issue Nov 29, 2023 that may be closed by this pull request
Fix routing in sequence/:id #947
Closed
ErykSol
ErykSol approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@ErykSol ErykSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job especialy added params validation on start of checks 👍

@patuwwy patuwwy merged commit b930b3d into devel Dec 8, 2023
19 checks passed
@patuwwy patuwwy deleted the refactor/host-seq-api-methods branch December 8, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patuwwy patuwwy patuwwy approved these changes

@ErykSol ErykSol ErykSol approved these changes

@alicja-gruzdz alicja-gruzdz Awaiting requested review from alicja-gruzdz

Assignees
No one assigned
Labels
to verify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix routing in sequence/:id
3 participants
@piotrek6641 @patuwwy @ErykSol