This repository has been archived by the owner on Feb 2, 2022. It is now read-only.
Implement data models #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements data models representing the resources captured by ScrAPD. This allows us to validate the data we are extracting, reduces the possibility to introduce incorrect values and prevents polluting the final data set. As this is a fundamental change, the PR is way bigger than a normal one, but the following items were also addressed: * Reorganize the modules based on the resources they process. * Reorganize the unit tests in suites and leverages `pytest.param` objects to assign test IDs and simplify the process of adding markers. * Update the formatters to render the models.
|
Something went wrong... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Implements data models representing the resources captured by ScrAPD.
This allows us to validate the data we are extracting, reduces the
possibility to introduce incorrect values and prevents polluting the
final data set.
As this is a fundamental change, the PR is way bigger than a normal
one, but the following items were also addressed:
pytest.paramobjects to assign test IDs and simplify the process of adding markers.
Checklist:
Fixes: #190