Skip to content
This repository has been archived by the owner on Feb 2, 2022. It is now read-only.

Refactor the JSON formatter #207

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Conversation

rgreinho
Copy link
Member

Types of changes

  • Code cleanup / Refactoring

Description

Refactors the JSON formatter to be able to reuse some functions outside
of this module.

Checklist:

  • [] I have updated the documentation accordingly
  • [] I have written unit tests

Refactors the JSON formatter to be able to reuse some functions outside
of this module.
@rgreinho rgreinho self-assigned this Sep 30, 2019
@rgreinho rgreinho added this to In progress in ScrAPD 3.0.0 via automation Oct 3, 2019
@rgreinho rgreinho added the kind/optimization Optimize an existing feature label Oct 3, 2019
@rgreinho
Copy link
Member Author

rgreinho commented Oct 4, 2019

Merging this to move forward. Reopen the associated issue if there is any problem.

@rgreinho rgreinho merged commit bd61038 into scrapd:master Oct 4, 2019
ScrAPD 3.0.0 automation moved this from In progress to Done Oct 4, 2019
@rgreinho rgreinho deleted the fix-formatter branch October 4, 2019 02:26
Copy link
Contributor

@mscarey mscarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/optimization Optimize an existing feature
Projects
No open projects
ScrAPD 3.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants