This repository has been archived by the owner on Feb 2, 2022. It is now read-only.
Update formatter.py #213
Merged
Update formatter.py #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgreinho
force-pushed
the
date-time-json-formats
branch
from
33a471f
to
9799ddc
Compare
Pydantic only supports a handful of date and time formats for (de)serialization: https://pydantic-docs.helpmanual.io/#datetime-types. This PR adjust the formats in our custom JSON serializer to allow us to leverage pydantic automatic serialization/deserialization.
rgreinho
force-pushed
the
date-time-json-formats
branch
from
9799ddc
to
affa9ea
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Pydantic only supports a handful of date and time formats for (de)serialization:
https://pydantic-docs.helpmanual.io/#datetime-types.
This PR adjust the formats in our custom JSON serializer.
This allows us to serialize and deserialize JSON objects.
Checklist: