New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Price rules rehaul #157

Open

manycoding opened this issue Aug 27, 2019 · 0 comments

Labels

Contributor

manycoding commented Aug 27, 2019 •

edited

Refactor compare_was_now, compare_prices_for_same_urls, compare_names_for_same_urls, compare_prices_for_same_names

compare_was_now:

compares numeric value between two job fields
Outputs >, <, =

compare_prices_for_same_urls

returns url field values difference between 2 jobs (new, same, missing)
for same urls, compares price

compare_names_for_same_urls

compares names for same between 2 jobs urls

compare_prices_for_same_names

returns name field values difference between 2 jobs (new, same, missing)
for same names, compares price

The last three do the same:

find given field difference - can go in a separate rule
compare certain field values between 'same' items. Items are found by a key, different from item_key (e.g. url/name)

manycoding added Type: Feature Type: Rule and removed Type: Rule labels

manycoding changed the title ~~Difference rule - price rules rehaul~~ Price rules rehaul

This was referenced Aug 27, 2019

Job fields difference #158

Closed

Compare field values between two jobs #159

Open

manycoding added this to the 0.3.7 milestone

manycoding removed this from the 0.3.7 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment