Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is not parsing properly the Last-Modified header value when is a Monday #1116

Closed
rustico opened this issue Jan 5, 2023 · 2 comments · Fixed by #1121
Closed

Is not parsing properly the Last-Modified header value when is a Monday #1116

rustico opened this issue Jan 5, 2023 · 2 comments · Fixed by #1121
Assignees
@serhii73
Labels
Status: Bug confirmed Type: Bug

Comments

@rustico
Copy link

rustico commented Jan 5, 2023

Hi,

Just in case, in the previous version we were able to parse the following 'Mon, 05 Dec 2022 19:43:03 GMT' without any problem and now is returning None.

This is happening only when is Monday.

It could be related to this commit: 89a5b29 ?

Thank you!

Best,
Nicolas.
@rustico rustico changed the title Is not parsing properly the Last-Modified header value Is not parsing properly the Last-Modified header value when is a Monday Jan 5, 2023
@Gallaecio
Copy link
Member

I have confirmed 89a5b29 as the cause.

@serhii73 serhii73 self-assigned this Jan 6, 2023
@rustico rustico mentioned this issue Jan 6, 2023
Open
@asadurski asadurski mentioned this issue Jan 10, 2023
Closed
serhii73 added a commit that referenced this issue Jan 10, 2023
@serhii73
Parse Monday
05727fc 
Close #1116
@serhii73 serhii73 mentioned this issue Jan 10, 2023
Merged
serhii73 added a commit that referenced this issue Jan 10, 2023
@serhii73
Parse Monday
cd80b9d 
Close #1116
serhii73 added a commit that referenced this issue Jan 11, 2023
@serhii73
Parse Monday (#1121)
1db73ee 
* Parse Monday

Close #1116

* Add test_known_issues
@serhii73
Copy link
Collaborator

I created a new issue where 1mon ago will be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serhii73 serhii73

Labels
Status: Bug confirmed Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parse Monday scrapinghub/dateparser
3 participants
@Gallaecio @rustico @serhii73