Finnish language additions #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The partitive and inessive forms were added for month and day names, since they are frequently used with dates. The original file only included the (common) misspelling of second, "sekuntti" - the correct one ("sekunti") was also added with inflections. I left the misspelling there, since it's quite common and can not be easily misinterpreted as something else.
Fixes #243
Fixes
Te original file only included
Current coverage is 94.09% (diff: 100%)@@ master #244 diff @@
==========================================
Files 32 32
Lines 2779 2779
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2615 2615
Misses 164 164
Partials 0 0
|
|
@vaelma I looked into it further. The I've added those tests back. Merging the PR now, thank you for your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #243, includes some additional date forms. Left out some test cases for dates like "27. tammikuuta 2016" ("27th January...") as discussed on Gitter.
Wikipedia on the ordinal dot, which is also used in dates: https://en.wikipedia.org/wiki/Ordinal_indicator#Finnish