Russian abbreviation weekdays

[christianfm10]

Added russian abbreviation weekdays:
Monday: Пнд
Tuesday: Втр
Wednesday: Срд
Thursday: Чтв
Friday: Птн
Saturday: Сбт
Sunday: Вск

Fixes #436

[codecov]

Codecov Report

Merging #484 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
+ Coverage   94.99%   94.99%   +<.01%     
==========================================
  Files         302      302              
  Lines        2457     2459       +2     
==========================================
+ Hits         2334     2336       +2     
  Misses        123      123

Impacted Files	Coverage Δ
dateparser/data/date_translation_data/ru.py	100% <ø> (ø)	⬆️
dateparser/timezone_parser.py	97.91% <0%> (+0.09%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66d5470...ceaa0fc. Read the comment docs.

[eLRuLL]

We'll need a maintener that knows russian that could approve this.

Also it becomes more evident that we should be splitting all this "dates" related information to something more structured. Maybe inside every language we should separate the files to:

• days
• months

Just to give more perspective, but maybe this approach could affect performance. Maybe just one file with a better structure defining all that information by sections.

@asadurski I would also like your input here. Thanks

[eLRuLL]

@christianfm10 please include tests

[lopuhin]

I assume more common two-letter abbreviations are handled elsewhere, new three-letter abbreviations look good to me, except for one strange capitalization.

[lopuhin]

Probably the last letter shouldn't be capitalized, so that would be Срд

[christianfm10]

Sorry, my bad.

[christianfm10]

I have already fixed it. By the way, can you review the tests that i added? 🙏

[asadurski]

Thanks for taking care of these!
However, for those updates to work, you need to run scripts/write_complete_data.py, which will merge them with already existing language tokens and will update ru.py language data file only with differences.
Then you need to commit that file too.
(please see https://github.com/scrapinghub/dateparser/blob/master/CONTRIBUTING.rst#guidelines-for-editing-translation-data)
Also, as @eLRuLL already mentioned, tests are essential here, so please include them too.

[christianfm10]

@asadurski thanks for your reply. I added "ru.py" file and tests, what do you think?

[eLRuLL]

I am reviewing this as accepted to not interfere with @lopuhin and @asadurski .

Thank you guys for jumping into this.

[lopuhin]

Looks good to me 👍 Left a suggestion for one more common abbreviation for Sunday, and a question regarding case.

[lopuhin]

Btw, another common one is Вскр

[lopuhin]

Probably not related to this PR, but I'm curious if case matters here, and why is пн lower but Пнд capitalized?

[noviluni]

Capitalization doesn't matter when processing dates. However, If we add two different versions of the same word both are added to the py file. This is going to be fixed in this PR by @asadurski: #487

[Gallaecio]

@christianfm10 Do you think you will have time to address @lopuhin’s feedback?

Otherwise, @eLRuLL, @lopuhin, @asadurski, shall we merge as is?

[eLRuLL]

totally up to @lopuhin and @asadurski at this point I think

[lopuhin]

In terms of Russian language, changes are good. From the dataparser side, I have the following questions:

• does capitalization matter? If yes then I can check in more detail which capitalization is better
• yaml and py files are different, is this fine?

[Gallaecio]

yaml and py files are different, is this fine?

It is not fine. We need to add a check for this to the CI.

[noviluni]

Hi @lopuhin
There is a PR adding tests to avoid merging different yaml - py files: #663.

On the other side, as answered in the inline comment, capitalization doesn't matter.