Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated parser.py #536

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Updated parser.py #536

merged 1 commit into from
Jan 17, 2020

Conversation

kamilnematli
Copy link
Contributor

@kamilnematli kamilnematli commented Jul 2, 2019

datetime(**params) on line 274 doing nothing and gives TypeError: function missing required argument 'day' (pos 3) for some inputs.

Fixes #336

datetime(**params) on line 274 doing nothing and gives TypeError: function missing required argument 'day' (pos 3) for some inputs.
Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it might be there to provoke that exception on purpose on invalid inputs, but I think that makes no sense within the loop.

The code is 3 years old, so I don’t think @waqasshabbir will remember whether he added it on purpose or it was a leftover from debugging or something.

It seems safe to remove to me.

@Gallaecio Gallaecio closed this Jul 8, 2019
@Gallaecio Gallaecio reopened this Jul 8, 2019
@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #536 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
+ Coverage   95.01%   95.09%   +0.07%     
==========================================
  Files         302      302              
  Lines        2466     2465       -1     
==========================================
+ Hits         2343     2344       +1     
+ Misses        123      121       -2
Impacted Files Coverage Δ
dateparser/parser.py 98.59% <ø> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11a761c...24851f7. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #536 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
+ Coverage   95.01%   95.09%   +0.07%     
==========================================
  Files         302      302              
  Lines        2466     2465       -1     
==========================================
+ Hits         2343     2344       +1     
+ Misses        123      121       -2
Impacted Files Coverage Δ
dateparser/parser.py 98.59% <ø> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11a761c...24851f7. Read the comment docs.

@Gallaecio Gallaecio merged commit 0bbba75 into scrapinghub:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError when parsing some numbers
3 participants