Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parsing of -0000 timezones #574

Merged
merged 2 commits into from
Feb 17, 2020
Merged

fix parsing of -0000 timezones #574

merged 2 commits into from
Feb 17, 2020

Conversation

anarcat
Copy link
Contributor

@anarcat anarcat commented Oct 11, 2019

This occurs namely on the XKCD feed available here:

https://www.xkcd.com/rss.xml

Fixes #402, fixes #548

This occurs namely on the XKCD feed available here:

https://www.xkcd.com/rss.xml

Fixes: scrapinghub#548
@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #574 into master will decrease coverage by 2.36%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #574      +/-   ##
==========================================
- Coverage   95.12%   92.76%   -2.37%     
==========================================
  Files         302      302              
  Lines        2503     2502       -1     
==========================================
- Hits         2381     2321      -60     
- Misses        122      181      +59
Impacted Files Coverage Δ
dateparser/timezones.py 100% <ø> (ø) ⬆️
dateparser/data/date_translation_data/nb.py 100% <ø> (ø) ⬆️
dateparser/parser.py 98.61% <ø> (+0.27%) ⬆️
dateparser/utils/strptime.py 92.68% <ø> (-7.32%) ⬇️
dateparser/languages/locale.py 98.39% <100%> (-0.27%) ⬇️
dateparser/freshness_date_parser.py 98.94% <100%> (ø) ⬆️
dateparser/calendars/hijri_parser.py 2.17% <0%> (-89.14%) ⬇️
dateparser/calendars/hijri.py 50% <0%> (-50%) ⬇️
dateparser/calendars/__init__.py 88.88% <0%> (-6.18%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90ffbf6...3ee167b. Read the comment docs.

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@seanthegeek
Copy link

Out of curiosity, why hasn't this been merged yet?

@noviluni
Copy link
Collaborator

Thank you @anarcat !

@noviluni noviluni merged commit 947cc77 into scrapinghub:master Feb 17, 2020
@anarcat anarcat deleted the tz0000 branch February 17, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants