Merge pull request #115 from scrapinghub/opengraph_uniform_reversed_p…

…recedence Reverse priorities for repeated properties in uniform format for opengraph
scrapinghub · Jun 7, 2019 · 713f70b · 713f70b
2 parents de219cb + f987d9a
commit 713f70b
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 2 deletions.
diff --git a/extruct/uniform.py b/extruct/uniform.py
@@ -4,7 +4,7 @@
 def _uopengraph(extracted):
     out = []
     for obj in extracted:
-        flattened = dict(obj['properties'])
+        flattened = dict(reversed(obj['properties']))
         t = flattened.pop('og:type', None)
         if t:
             flattened['@type'] = t

diff --git a/tests/samples/songkick/elysianfields.html b/tests/samples/songkick/elysianfields.html
@@ -30,6 +30,7 @@
     <meta property="og:description" content="Buy tickets for an upcoming Elysian Fields concert near you. List of all Elysian Fields tickets and tour dates for 2017.">
     <meta property="og:url" content="http://www.songkick.com/artists/236156-elysian-fields">
     <meta property="og:image" content="http://images.sk-static.com/images/media/img/col4/20100330-103600-169450.jpg">
+    <meta property="og:image" content="http://images.sk-static.com/SECONDARY_IMAGE.jpg">
   </head>
   <body>
     <script>

diff --git a/tests/samples/songkick/elysianfields.json b/tests/samples/songkick/elysianfields.json
@@ -202,6 +202,10 @@
                 [
                     "og:image",
                     "http://images.sk-static.com/images/media/img/col4/20100330-103600-169450.jpg"
+                ],
+                [
+                    "og:image",
+                    "http://images.sk-static.com/SECONDARY_IMAGE.jpg"
                 ]
             ]
         }
@@ -233,6 +237,9 @@
             "http://ogp.me/ns#image": [
                 {
                     "@value": "http://images.sk-static.com/images/media/img/col4/20100330-103600-169450.jpg"
+                },
+                {
+                    "@value": "http://images.sk-static.com/SECONDARY_IMAGE.jpg"
                 }
             ],
             "http://ogp.me/ns#site_name": [

diff --git a/tests/test_extruct.py b/tests/test_extruct.py
@@ -5,6 +5,7 @@
 import pytest
 
 import extruct
+from extruct import SYNTAXES
 from tests import get_testdata, jsonize_dict, replace_node_ref_with_node_id
 
 
@@ -16,6 +17,21 @@ def test_all(self):
         body = get_testdata('songkick', 'elysianfields.html')
         expected = json.loads(get_testdata('songkick', 'elysianfields.json').decode('UTF-8'))
         data = extruct.extract(body, base_url='http://www.songkick.com/artists/236156-elysian-fields')
+        # See test_rdfa_not_preserving_order()
+        del data['rdfa'][0]['http://ogp.me/ns#image']
+        del expected['rdfa'][0]['http://ogp.me/ns#image']
+        self.assertEqual(jsonize_dict(data), expected)
+
+    @pytest.mark.xfail
+    def test_rdfa_not_preserving_order(self):
+        # See https://github.com/scrapinghub/extruct/issues/116
+        # RDFa is not preserving ordering on duplicated properties. So this
+        # test sometimes fails for property 'http://ogp.me/ns#image'
+        body = get_testdata('songkick', 'elysianfields.html')
+        expected = json.loads(get_testdata('songkick', 'elysianfields.json').decode('UTF-8'))
+        data = extruct.extract(body,
+                               base_url='http://www.songkick.com/artists/236156-elysian-fields',
+                               syntaxes=['rdfa'])
         self.assertEqual(jsonize_dict(data), expected)
 
     def test_microdata_custom_url(self):

diff --git a/tests/test_uniform.py b/tests/test_uniform.py
@@ -1,7 +1,7 @@
 import unittest
 
 import extruct
-from extruct.uniform import _flatten, infer_context, flatten_dict
+from extruct.uniform import _flatten, infer_context, flatten_dict, _uopengraph
 from tests import get_testdata
 
 
@@ -27,6 +27,16 @@ def test_uopengraph(self):
         data = extruct.extract(body, syntaxes=['opengraph'], uniform=True)
         self.assertEqual(data['opengraph'], expected)
 
+    def test_uopengraph_duplicated_priorities(self):
+        # Ensures that first seen property is kept when flattening
+        data = _uopengraph([{'properties':
+                                 [('prop_{}'.format(k), 'value_{}'.format(v))
+                                  for k in range(5)
+                                  for v in range(5)],
+                             'namespace': 'namespace'}])
+        for k in range(5):
+            assert data[0]['prop_{}'.format(k)] == 'value_0'
+
     def test_umicroformat(self):
         expected = [ { '@context': 'http://microformats.org/wiki/',
                      '@type': ['h-hidden-phone', 'h-hidden-tablet'],