Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG+2] Fix: scrapinghub/extruct#84 try to parse JSON-LD with control characters #85

Merged
merged 10 commits into from
Aug 8, 2018
Merged

[MRG+2] Fix: scrapinghub/extruct#84 try to parse JSON-LD with control characters #85

merged 10 commits into from
Aug 8, 2018

Commits on Jul 31, 2018

  1. Fix: scrapinghub#84 try to parse JSON-LD with control characters.

    Shiquan Wang committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    ddb25ae View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2018

  1. Fix: A typo.

    Shiquan Wang committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    3b36247 View commit details
    Browse the repository at this point in the history

  2. Fix: Make expected list in tests in order to be aligned with mf2py.

    Shiquan Wang committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    00d1796 View commit details
    Browse the repository at this point in the history

  3. Add: Add test for JSON-LD data with control characters.

    Shiquan Wang committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    af34117 View commit details
    Browse the repository at this point in the history

  4. Fix: Make tests pass, json.JSONDecodeError is only available for Py… 

    …thon 3.5 and on.
    Shiquan Wang committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    2869a02 View commit details
    Browse the repository at this point in the history

  5. Mod: Use ValueError again since json.JSONDecodeError exists from … 

    …py35

Seems can pass unit tests and coverage tests finally.
    Shiquan Wang committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    b95cdc8 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2018

  1. Mod: Remove leading comments and allow control characters directly.

    Shiquan Wang committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    d1e64b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2018

  1. Mod: Make comment removal a fallback when failed.

    Shiquan Wang committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    1874473 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2018

  1. Add: Add test for comment, control characters individually and together.

    Shiquan Wang committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    e3b0c4a View commit details
    Browse the repository at this point in the history

  2. Mod: Make each test for a single and simple case.

    @shiquanwang
    shiquanwang committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    d839faa View commit details
    Browse the repository at this point in the history