Add __version__

[serhii73]

Close #86

[codecov]

Codecov Report

Merging #87 (df63ff3) into master (7f287bb) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head df63ff3 differs from pull request most recent head 682a1b9. Consider uploading reports for the commit 682a1b9 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   99.09%   99.10%   +0.01%     
==========================================
  Files          85       86       +1     
  Lines         331      335       +4     
  Branches       60       60              
==========================================
+ Hits          328      332       +4     
  Misses          1        1              
  Partials        2        2              

Impacted Files	Coverage Δ
number_parser/__init__.py	100.00% <100.00%> (ø)

[Gallaecio]

✔️

That said:

• It feels weird to have 2 almost-identical, same-name functions.
• I find the approach from Scrapy slightly better, in that it makes me less uneasy to read the version from a file that only contains the version, and not from a file that contains more stuff.
  • https://github.com/scrapy/scrapy/blob/b337c986ca1188f4b26d30c9ae4bb7ff457ed505/setup.py#L7
  • https://github.com/scrapy/scrapy/blob/master/scrapy/VERSION
  • https://github.com/scrapy/scrapy/blob/b337c986ca1188f4b26d30c9ae4bb7ff457ed505/scrapy/__init__.py#L31
  • https://github.com/scrapy/scrapy/blob/b337c986ca1188f4b26d30c9ae4bb7ff457ed505/.bumpversion.cfg#L7

[Gallaecio]

While the author and author_email should probably stay unless @arnavkapoor decides otherwise, we should probably update the URL.