Migrate CI to github actions #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 7, 2022 09:32
This reverts commit b8f013f.
|
The executed jobs remind me that, if you plan on opening a pull request, it is better to create your feature branch on a fork of this repository. Otherwise, jobs run twice, once for the branch, and another time for the push. |
Gallaecio
reviewed
Nov 7, 2022
…eded step. Changed mypy to run with latest py version used in tests
Good point 👍 I also noticed that the tests were running twice, which is non optimal. I added a check in 6ec36ee so that they'd only get run once on non-fork PR (like this one). Seen here: zopefoundation/meta#145 (comment) |
Gallaecio
approved these changes
Nov 7, 2022
kmike
reviewed
Nov 15, 2022
kmike
reviewed
Nov 15, 2022
added 2 commits
November 22, 2022 15:27
|
Awesome, thanks @ivsanro1! |
kmike
added a commit
that referenced
this pull request
Nov 22, 2022
* Added test gha * Change codecov in workflows/main.yml * Added mypy in gh action yaml * Double checking ghe test fails * Revert "Double checking ghe test fails" This reverts commit b8f013f. * Added publish github action (untested) * Removed travis-ci yml file * Added check to avoid running tests twice on non-fork PR. Removed unneeded step. Changed mypy to run with latest py version used in tests * Removed "v" in tag regex of publish.yml. Changed badge of CI from travis to gh workflows * Removed travis-ci from badge in README.rst Co-authored-by: Ivan Sanchez <ivan.sanchez@zyte.com> Co-authored-by: Iván Sánchez <30293331+ivsanro1@users.noreply.github.com> Co-authored-by: Ivan Sanchez <ivan.sanchez@zyte.com>
|
Thanks for rewiew @kmike @Gallaecio ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR on top of #53, fixes issue #52
The Github Actions yml files were heavily inspired in the ones of https://github.com/scrapy/parsel (thanks @Gallaecio for the examples!)
I have not tested the
publish.ymlthough. When we make a version release it should get triggered and upload the version to pypi. I also added thePYPI_TOKENto gh actions secrets (it was in.travis.ymlbefore).