Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting CLD2_PATH in environment #1

Merged
merged 1 commit into from Aug 6, 2015

Conversation

pquentin
Copy link
Contributor

CLD2 and python-cld2 are currently difficult to deploy. Eventually CLD2 should install to standard locations and python-cld2 should find the files it needs in those locations, but for now, how about not requiring to edit setup.py? This would make my life a bit easier. :)

Thanks for python-cld2!

@pquentin
Copy link
Contributor Author

I'm not sure who should review this. It looks like @mikemccand wrote the code (this is what the README says), but @vshlapakov appears in the commits. Is this the correct repository to send a pull request to?

@vshlapakov
Copy link
Contributor

Just have seen this PR, my apologies @pquentin. The library itself belongs to Michael, so I'm redirecting all thanks to him :) When I was working on it, there was only abandoned code (it seemed so for me) on code.google.com, and I had to improve it a bit for our internal use (and for our build system), so I wasn't sure about use of this repo for others and just cloned the project (with all needed links and original readme). Now as I see that they ported the code to github, so probably it's a good idea to prepare PR using these changes. Thanks for pointing me, I'll merge this PR but it'd be much better to contribute to the original source repo in future.

vshlapakov added a commit that referenced this pull request Aug 6, 2015
Allow setting CLD2_PATH in environment
@vshlapakov vshlapakov merged commit 433f91e into scrapinghub:master Aug 6, 2015
@pquentin
Copy link
Contributor Author

Thank you @vshlapakov! Just to be sure, are you referring to https://github.com/mikemccand/chromium-compact-language-detector?

@vshlapakov
Copy link
Contributor

Yw! @pquentin Yeap, that repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants