Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump msgpack version #147

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Bump msgpack version #147

merged 1 commit into from
Feb 25, 2020

Conversation

pardo
Copy link
Contributor

@pardo pardo commented Feb 21, 2020

If you are using the latest msgpack will break when trying to retrieve data

encoding option is removed. UTF-8 is used always.

https://github.com/msgpack/msgpack-python#major-breaking-changes-in-msgpack-10

Not sure how the bump and the code change might affect msgpack-pypy

~/.cache/pypoetry/virtualenvs/project-6gE1vKXj-py3.8/lib/python3.8/site-packages/scrapinghub/hubstorage/serialization.py in mpdecode(iterable)
     26 
     27 def mpdecode(iterable):
---> 28     unpacker = Unpacker(encoding='utf8')
     29     for chunk in iterable:
     30         unpacker.feed(chunk)

msgpack/_unpacker.pyx in msgpack._cmsgpack.Unpacker.__init__()

TypeError: __init__() got an unexpected keyword argument 'encoding'

@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files          28       28           
  Lines        1938     1938           
=======================================
  Hits         1821     1821           
  Misses        117      117
Impacted Files Coverage Δ
scrapinghub/hubstorage/serialization.py 97.14% <100%> (ø) ⬆️
scrapinghub/client/utils.py 94.25% <0%> (ø) ⬆️
scrapinghub/hubstorage/batchuploader.py 94.15% <0%> (ø) ⬆️
scrapinghub/legacy.py 98.41% <0%> (ø) ⬆️
scrapinghub/hubstorage/resourcetype.py 97.35% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef7c41a...13915e3. Read the comment docs.

@vshlapakov vshlapakov merged commit 1788eef into scrapinghub:master Feb 25, 2020
@vshlapakov
Copy link
Contributor

@pardo Looks good to me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants