Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from Travis to GH actions #162

Merged
merged 5 commits into from
Dec 30, 2021
Merged

switch from Travis to GH actions #162

merged 5 commits into from
Dec 30, 2021

Conversation

pawelmhm
Copy link
Member

No description provided.

@pawelmhm
Copy link
Member Author

pawelmhm commented Dec 27, 2021

@Gallaecio @ejulio switched from Travis to GH actions, tests passing for 3.6 until 3.9. Having working CI is an essential condition for doing any other work, e.g. on porting to 3.10. Cassettes are working fine in 3.9 but failing in Python 3.10. Need to investigate why tests are failing with cassettes via vcrpy https://github.com/kevin1024/vcrpy there seems to be something with this library. Latest release of vcrpy was in October 2020, I'm not sure how active project is, perhaps we should switch to different library providing similar functionality.

Copy link
Member

@elacuesta elacuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @pawelmhm, thanks.
Can we keep tox.ini just like we have for other projects? (scrapy, parsel, itemadapter come to mind). That way we can handle the msgpack tests (and other checks like flake8/black/pylint) more easily IMHO.
Lastly, it would be good to have a workflow to publish the package to PyPI. I get that the Travis build is not currently working anyway, so I don't think that should be a blocker for this PR.

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@pawelmhm
Copy link
Member Author

thanks for review @elacuesta I'll include your feedback in next commit

@pawelmhm pawelmhm force-pushed the gh-actions branch 3 times, most recently from 2e8cb28 to 40cec82 Compare December 27, 2021 17:13
@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #162 (0d4b022) into master (c70137a) will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   93.96%   94.27%   +0.31%     
==========================================
  Files          28       28              
  Lines        1938     1958      +20     
==========================================
+ Hits         1821     1846      +25     
+ Misses        117      112       -5     
Impacted Files Coverage Δ
scrapinghub/client/proxy.py 95.71% <100.00%> (ø)
scrapinghub/client/__init__.py 100.00% <0.00%> (ø)
scrapinghub/hubstorage/client.py 98.00% <0.00%> (+0.02%) ⬆️
scrapinghub/legacy.py 98.45% <0.00%> (+0.03%) ⬆️
scrapinghub/hubstorage/resourcetype.py 97.40% <0.00%> (+0.05%) ⬆️
scrapinghub/client/spiders.py 97.61% <0.00%> (+0.05%) ⬆️
scrapinghub/client/frontiers.py 89.25% <0.00%> (+0.46%) ⬆️
scrapinghub/client/jobs.py 86.42% <0.00%> (+0.71%) ⬆️
scrapinghub/hubstorage/collectionsrt.py 86.27% <0.00%> (+1.96%) ⬆️
scrapinghub/client/exceptions.py 84.84% <0.00%> (+3.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d30aced...0d4b022. Read the comment docs.

@pawelmhm
Copy link
Member Author

pawelmhm commented Dec 28, 2021

@elacuesta

  • added pypy and python 2.7
  • codecov uplodad via github action
  • publish yml action (launched on new release in github, I did not run it, it should be tested properly, maybe uploading to test pypy, we can do it on release)
  • brought back tox

@pawelmhm
Copy link
Member Author

About PYPI_TOKEN I don't have permissions to create one so we need to wait for @Gallaecio, would be also nice to have token to testpypi to test it first on first release via github.

Copy link
Member

@elacuesta elacuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, many thanks @pawelmhm. The PyPI token was added to the repo secrets some time ago by @Gallaecio, we don't need to worry about it.

@elacuesta elacuesta merged commit fe63256 into master Dec 30, 2021
@elacuesta elacuesta deleted the gh-actions branch March 9, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants