Improve tests #86
Merged
Improve tests #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vshlapakov
reviewed
Nov 1, 2017
|
Sweet, I like them, merged your changes into my branch right away :) |
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 93.26% 93.26%
=======================================
Files 28 28
Lines 1870 1870
=======================================
Hits 1744 1744
Misses 126 126Continue to review full report at Codecov.
|
vshlapakov
reviewed
Nov 2, 2017
| frontier.flush() | ||
|
|
||
| assert frontier.newcount == 150 + old_count | ||
|
|
||
| # insert repeated fingerprints | ||
| fps4 = [{'fp': '/index_%s.html' % fp} for fp in range(0, batch_size)] |
There was a problem hiding this comment.
@immerrr last question about the PR before merge, why the test with repeated fps was changed?
There was a problem hiding this comment.
Because fps4 was unused and fps3 were used as "repeated fingerprints" instead.
There was a problem hiding this comment.
Oh, thanks for cleaning it, I didn't spot it even now 🤦♂️
|
Thanks again @immerrr! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pytest-catchlog for reviewing errors sent to logs, e.g. from background threads.
It also adds a rather unique frontier name for each test case so that test case ordering doesn't affect the vcrpy cassettes.