Send request data as str/bytes #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
=======================================
Coverage 93.26% 93.26%
=======================================
Files 28 28
Lines 1870 1870
=======================================
Hits 1744 1744
Misses 126 126
Continue to review full report at Codecov.
|
dangra
reviewed
Nov 22, 2017
| @@ -54,7 +54,7 @@ def _iter_lines(self, _path, **kwargs): | |||
| kwargs['url'] = urlpathjoin(self.url, _path) | |||
| kwargs.setdefault('auth', self.auth) | |||
| if 'jl' in kwargs: | |||
| kwargs['data'] = jlencode(kwargs.pop('jl')) | |||
There was a problem hiding this comment.
I think we need a comment here explaining why the .encode() is needed and what upstream bug it is preventing.
There was a problem hiding this comment.
@dangra Good point, updated 👌
vshlapakov
force-pushed
the
send-body-as-bytes
branch
from
d602f7c
to
3939113
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short fix to overcome urllib3/urllib3#717 related to large POST requests via SSL raising
SSL3_WRITE_PENDINGerror.