Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

Commit

Permalink
Merge pull request #4 from scrapinghub/fix-deploy-tests
Browse files Browse the repository at this point in the history
Minor test fixes
  • Loading branch information
dangra committed May 3, 2016
2 parents 55a3624 + d243e9e commit 154d932
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions tests/test_deploy.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def test_prepare_deploy_params(self, mocked):
add_fake_setup_py(tmpdir)
assert _prepare_deploy_params(
123, 'test-vers', 'registry/user/project',
None, None, None, False) == {
None, None, None) == {
'image_url': 'registry/user/project',
'project': 123,
'pull_insecure_registry': True,
Expand All @@ -83,11 +83,10 @@ def test_prepare_deploy_params_more_params(self, mocked):
' "pass", "username": "user"}')
assert _prepare_deploy_params(
123, 'test-vers', 'registry/user/project',
'user', 'pass', 'email@mail', True) == {
'user', 'pass', 'email@mail') == {
'image_url': 'registry/user/project',
'project': 123,
'pull_auth_config': expected_auth,
'sync': True,
'scripts': 'scriptA.py,scriptB.py',
'spiders': 'a1f,abc,spi-der',
'version': 'test-vers'}
2 changes: 1 addition & 1 deletion tests/test_upload.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def test_cli(self, build, push, deploy):
result = runner.invoke(
cli, ["dev", "-d", "--version", "test",
"--username", "user", "--password", "pass",
"--email", "mail", "--sync"])
"--email", "mail", "--async"])
assert result.exit_code == 0
build.assert_called_with('dev', True, 'test')
push.assert_called_with('dev', True, 'test', 'user', 'pass', 'mail')
Expand Down

0 comments on commit 154d932

Please sign in to comment.