Update setup.py #235
Merged
Update setup.py #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redapple
reviewed
Mar 3, 2017
setup.py
Outdated
| 'docker-py', | ||
| 'pip', | ||
| 'PyYAML', | ||
| 'retrying' |
chekunkov
force-pushed
the
update-setup.py
branch
from
dd8c3d5
to
8d3f961
Compare
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
=======================================
Coverage 89.06% 89.06%
=======================================
Files 30 30
Lines 1728 1728
=======================================
Hits 1539 1539
Misses 189 189Continue to review full report at Codecov.
|
redapple
approved these changes
Mar 27, 2017
|
@chekunkov , it seems six>=1.7.0 is needed too. See #239 |
chekunkov
force-pushed
the
update-setup.py
branch
from
8d3f961
to
00b58b0
Compare
|
@redapple added |
Pin scrapinghub (>=1.9.0) and six (>=1.7.0) versions. Add Python 3.6 trove classifier.
chekunkov
force-pushed
the
update-setup.py
branch
from
00b58b0
to
065938c
Compare
|
Thanks guys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin scrapinghub (>=1.9.0) and six (>=1.7.0) versions.
Add Python 3.6 trove classifier.
It may be a good idea to have versions for other requirements pinned to some meaningful ranges, e.g. I'm not sure shub works well with all versions of docker-py or all versions of click.
Fixes #239