Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E231 and E501 flake8 errors in CI #433

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

rennerocha
Copy link
Contributor

This PR fixes the check errors in #432 .

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (519809d) 89.46% compared to head (6215b56) 89.29%.

❗ Current head 6215b56 differs from pull request most recent head 7399bd9. Consider uploading reports for the commit 7399bd9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
- Coverage   89.46%   89.29%   -0.17%     
==========================================
  Files          34       34              
  Lines        2430     2401      -29     
==========================================
- Hits         2174     2144      -30     
- Misses        256      257       +1     
Files Coverage Δ
shub/deploy.py 90.44% <100.00%> (-0.07%) ⬇️

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rennerocha rennerocha mentioned this pull request Nov 7, 2023
@Gallaecio Gallaecio merged commit e6f35c0 into scrapinghub:master Nov 7, 2023
15 of 24 checks passed
@Gallaecio
Copy link
Member

Thanks, Renne!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants