Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for <3.8 #440

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

branchvincent
Copy link
Contributor

Follow up to #438 (comment) along with CI simplification and an explicit dep on setuptools for 3.12

Closes #406

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.43%. Comparing base (6253fb8) to head (de4b5d1).

❗ Current head de4b5d1 differs from pull request most recent head bea565b. Consider uploading reports for the commit bea565b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
- Coverage   89.44%   89.43%   -0.01%     
==========================================
  Files          34       34              
  Lines        2406     2405       -1     
==========================================
- Hits         2152     2151       -1     
  Misses        254      254              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines -13 to -15
[testenv:min]
deps =
{[testenv]deps}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see this was the same as py.

Ideally we should have a min env with pinned minimum versions of dependencies, but since it was not there, I’m OK with removing it and adding it back properly later in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drop support for Python 2.7, 3.5, 3.6
2 participants