feature: add-smtp-mail #204
Conversation
|
|
||
|
|
||
| class SendSmtpEmail(SendEmail): | ||
| smtp_host = "smtp.gmail.com" |
There was a problem hiding this comment.
This needs to be provided by the user as a mandatory setting. Do not set a fixed default.
| return kwargs | ||
|
|
||
| def send_message(self, message): | ||
| if not self.sender: |
There was a problem hiding this comment.
Required arguments needs to be validated when instantiating the Action (__init__), not when sending the e-mail.
| if not self.to: | ||
| raise NotConfigured("You must provide the receiver.") | ||
|
|
||
| if not self.sender or not self.to: |
There was a problem hiding this comment.
Because of your previous validation, this will never be executed.
| if not self.sender or not self.to: | ||
| return | ||
|
|
||
| server = smtplib.SMTP(self.smtp_host, self.smtp_port) |
There was a problem hiding this comment.
Sometimes using smtplib.SMTP is not appropriated and you need to use smtplib.SMTP_SSL. It will be interesting to have an option so the user can define which one to use depending on the needs of the SMTP server being connected.
There was a problem hiding this comment.
Maybe it is worth checking https://docs.scrapy.org/en/latest/topics/email.html
There was a problem hiding this comment.
It makes sense. Using the built-in SMTP method from Scrapy would be a good solution.
|
This feature is being continued in #345 |
hello i just created new PR for smtp mail action