Close spider by stats [#47][#50] #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gallaecio
reviewed
Sep 23, 2019
| ) | ||
| pipeline._set_crawler(crawler) |
There was a problem hiding this comment.
Why not pass it as a parameter to cls()?
| if stat_current_value > max_errors_allowed: | ||
| self.crawler.engine.close_spider( | ||
| spider, | ||
| 'Spidermon: No of errors are greater then the expected no of errors {} > {}'.format( |
There was a problem hiding this comment.
I think we should not call them errors (they could be warnings or something else entirely), and I would include the name of the specific stat that triggers the spider closing.
Suggested change
| 'Spidermon: No of errors are greater then the expected no of errors {} > {}'.format( | |
| 'Spidermon: The value of stat {} ({}) went above the configured limit ({})'.format(stat_name, stat_current_value, max_errors_allowed) |
rennerocha
requested changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an initial version of the solution.
I have added a new setting in spidermon as proposed by @raphapassini above
Note: Documentation is not added so far
I have implemented the solution
Please have a look
#47
#50