Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slack dependency name issue #367

Merged
merged 1 commit into from Nov 4, 2022

Conversation

VMRuiz
Copy link
Collaborator

@VMRuiz VMRuiz commented Nov 4, 2022

Fixes #363

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 74.62% // Head: 74.62% // No change to project coverage 👍

Coverage data is based on head (ad694d5) compared to base (f6406b7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   74.62%   74.62%           
=======================================
  Files          73       73           
  Lines        3113     3113           
  Branches      366      366           
=======================================
  Hits         2323     2323           
  Misses        725      725           
  Partials       65       65           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Gallaecio Gallaecio merged commit 46338b0 into scrapinghub:master Nov 4, 2022
@VMRuiz VMRuiz deleted the fix_slack_deps branch February 8, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No dep on slack-sdk
3 participants