-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 369 reestructure spidermon contrib monitors #386
Issue 369 reestructure spidermon contrib monitors #386
Conversation
kennyaires
commented
Feb 8, 2023
- Split spidermon/contrib/scrapy/monitors.py's content into different submodules
- Create a spidermon/contrib/scrapy/monitors/ folder
- Create an init.py file inside that folder that imports everything from the submodules for backward compatibility
- Create submodules inside spidermon/contrib/scrapy/monitors/
- Update the docs sections so they import everything from the submodules instead of specifying individual classes out of spidermon/contrib/scrapy/monitors.py
…on-contrib-monitors
Codecov ReportBase: 75.93% // Head: 76.00% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #386 +/- ##
==========================================
+ Coverage 75.93% 76.00% +0.06%
==========================================
Files 73 76 +3
Lines 3179 3188 +9
Branches 376 376
==========================================
+ Hits 2414 2423 +9
Misses 695 695
Partials 70 70
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hi guys, I made the changes accordingly, please review. |
…o issue-369-reestructure-spidermon-contrib-monitors
Synced with master, ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR to work with latest changes in master branch
…o issue-369-reestructure-spidermon-contrib-monitors
synced with master |
I tested it locally and it seems to work fine with both old and new paths. Merging it now. |