Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 369 reestructure spidermon contrib monitors #386

Conversation

kennyaires
Copy link
Contributor

  • Split spidermon/contrib/scrapy/monitors.py's content into different submodules
  • Create a spidermon/contrib/scrapy/monitors/ folder
  • Create an init.py file inside that folder that imports everything from the submodules for backward compatibility
  • Create submodules inside spidermon/contrib/scrapy/monitors/
  • Update the docs sections so they import everything from the submodules instead of specifying individual classes out of spidermon/contrib/scrapy/monitors.py

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 75.93% // Head: 76.00% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (71af654) compared to base (7766fad).
Patch coverage: 94.11% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
+ Coverage   75.93%   76.00%   +0.06%     
==========================================
  Files          73       76       +3     
  Lines        3179     3188       +9     
  Branches      376      376              
==========================================
+ Hits         2414     2423       +9     
  Misses        695      695              
  Partials       70       70              
Impacted Files Coverage Δ
spidermon/contrib/scrapy/monitors/base.py 92.30% <92.30%> (ø)
spidermon/contrib/scrapy/monitors/__init__.py 100.00% <100.00%> (ø)
spidermon/contrib/scrapy/monitors/monitors.py 97.84% <100.00%> (ø)
spidermon/contrib/scrapy/monitors/suites.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kennyaires kennyaires linked an issue Feb 8, 2023 that may be closed by this pull request
@kennyaires
Copy link
Contributor Author

Hi guys,

I made the changes accordingly, please review.

…o issue-369-reestructure-spidermon-contrib-monitors
@kennyaires
Copy link
Contributor Author

Synced with master, ready to merge.

@VMRuiz VMRuiz self-requested a review February 27, 2023 09:52
Copy link
Collaborator

@VMRuiz VMRuiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR to work with latest changes in master branch

…o issue-369-reestructure-spidermon-contrib-monitors
@kennyaires
Copy link
Contributor Author

synced with master

@VMRuiz
Copy link
Collaborator

VMRuiz commented Feb 27, 2023

I tested it locally and it seems to work fine with both old and new paths. Merging it now.

@VMRuiz VMRuiz merged commit 9c20913 into scrapinghub:master Feb 27, 2023
@VMRuiz VMRuiz added this to the 1.18.0 milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

idea: Restructure spidermon.contrib.scrapy.monitors
4 participants