Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Field names containing '_items' crash field coverage #437

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

VMRuiz
Copy link
Collaborator

@VMRuiz VMRuiz commented Mar 8, 2024

Fixes #428

It only cover the case where the fields ends with "_items" but is prefixed with something else like "count_items".
Using only _items as field name is still not compatible with the coverage count. We may be able to make it work but it would require a significant rewrite of calculate_field_coverage

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.43%. Comparing base (6b3503b) to head (957104a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #437   +/-   ##
=======================================
  Coverage   79.43%   79.43%           
=======================================
  Files          76       76           
  Lines        3229     3229           
  Branches      536      536           
=======================================
  Hits         2565     2565           
  Misses        593      593           
  Partials       71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VMRuiz VMRuiz merged commit 8493465 into master Mar 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field names containing "_items" crash field coverage
2 participants