Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Scrapinghub jobs.list Method Called with Incorrect Filter Parameter #446

Merged
merged 3 commits into from
May 7, 2024

Conversation

VMRuiz
Copy link
Collaborator

@VMRuiz VMRuiz commented May 6, 2024

Fixes #445

@VMRuiz VMRuiz requested review from curita and Gallaecio May 6, 2024 13:51
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.51%. Comparing base (f0d8ea5) to head (9df6953).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
+ Coverage   79.39%   79.51%   +0.12%     
==========================================
  Files          76       76              
  Lines        3237     3237              
  Branches      537      537              
==========================================
+ Hits         2570     2574       +4     
+ Misses        595      593       -2     
+ Partials       72       70       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@curita curita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing it so quickly 🙏

spidermon/contrib/scrapy/monitors/monitors.py Outdated Show resolved Hide resolved
@VMRuiz VMRuiz merged commit 562c024 into master May 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrapinghub jobs.list method called with incorrect filter parameter
3 participants