Merge pull request #134 from steiler/sendcommandschecklen

SendCommands return early if commands len == 0

.golangci.yaml

@@ -25,7 +25,6 @@ linters:
     - asciicheck
     - bodyclose
     - decorder
-    - depguard
     - dogsled
     - dupl
     - dupword

driver/generic/sendcommands.go

@@ -1,6 +1,8 @@
 package generic
 
 import (
+	"fmt"
+
 	"github.com/scrapli/scrapligo/response"
 	"github.com/scrapli/scrapligo/util"
 )
@@ -12,6 +14,10 @@ func (d *Driver) SendCommands(
 ) (*response.MultiResponse, error) {
 	d.Logger.Infof("SendCommands requested, sending '%s'", commands)
 
+	if len(commands) == 0 {
+		return nil, fmt.Errorf("%w: no inputs provided", util.ErrNoOp)
+	}
+
 	op, err := NewOperation(opts...)
 	if err != nil {
 		return nil, err

driver/generic/sendcommands_test.go

@@ -162,3 +162,16 @@ func TestSendCommandsFromFile(t *testing.T) {
 		t.Run(testName, f)
 	}
 }
+
+func TestSendCommandsNoOp(t *testing.T) {
+	testName := "send-commands-no-op"
+
+	t.Logf("%s: starting", testName)
+
+	d, _ := prepareDriver(t, testName, "send-commands-simple.txt")
+
+	_, err := d.SendCommands(nil)
+	if err == nil {
+		t.Fatalf("no-op send commands did not return ErrNoOp")
+	}
+}

util/errors.go

@@ -27,4 +27,7 @@ var (
 	ErrNetconfError = errors.New("errNetconfError")
 	// ErrOperationError is returned for any "operation" issues -- mostly meaning ops timeouts.
 	ErrOperationError = errors.New("errOperationError")
+	// ErrNoOp is an error returned when a "no op" event happens -- that is a SendCommands or
+	// SendConfigs method is called with an empty command/config slice provided.
+	ErrNoOp = errors.New("errNoOp")
 )